Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Global: add global validators to settings #2078

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Sep 27, 2021

Changes

  • ValidateInstanceInContext split into maya and nuke plugin
    • added settings for each of them
  • context anatomy collector also stores task type of context
  • start/stop timer plugins are using settings stored in context instead of loading them again
  • ValidateIntent is for all hosts by default and added profiles to filter validations (by default is plugin disabled)
  • ValidateVersion added active attribute to be able define if is activated by default

QUESTIONS

  • ValidateContainers - currently has settings in each host settings and not sure if should be added to global publish plugins settings and if yes than it will probably need profiles but at the same time should have optional (maybe) does it make sense to have both optional + active and profiles under that?
  • ValidateResources I actually don't know why are resources validated? is required does not need settings

@mkolar
Copy link
Member

mkolar commented Sep 27, 2021

Task linked: PYPE-1332 Add Global validators to settings

@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Sep 27, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this Sep 27, 2021
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review September 28, 2021 07:59
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ValidateVersion active attribute in setting schema

@iLLiCiTiT
Copy link
Member Author

missing ValidateVersion active attribute in setting schema

Fixed

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fintastic ;)

@iLLiCiTiT iLLiCiTiT merged commit a6aa8c1 into develop Oct 1, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/PYPE-1332_Add-Global-validators-to-settings branch December 13, 2021 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants